Handle null altitudes when reading positions #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altitudes are nullable in positions but could not be read because deserialization was done into double[].
This PR fixes this by reading positions using the JSON reader directly, token by token. As a consequence, benchmark shows that reading positions are also slightly faster.
Unit tests are added, not only for reading altitudes but also for reading string literals and numbers as strings (added in PR #19).
Example of GeoJSON that was failing before, but works with the changes in this PR. Note altitude "null" at coordinate 3.