Skip to content

Rewrite using TypeScript#8

Open
GeorgySk wants to merge 8 commits intomasterfrom
to_typescript
Open

Rewrite using TypeScript#8
GeorgySk wants to merge 8 commits intomasterfrom
to_typescript

Conversation

@GeorgySk
Copy link
Owner

@GeorgySk GeorgySk commented Oct 10, 2024

  • Fix styles that don't get passed from the "New" button.
  • Fix missing button in full-page tables.
  • Add a note in README about building the extension.
  • Fix a default cursor changing to a text cursor after clicking a button.

@GeorgySk GeorgySk self-assigned this Oct 10, 2024
@GeorgySk
Copy link
Owner Author

Clicking button suddenly broke. Currently, it throws this error:

content.js:125 Uncaught TypeError: Cannot read properties of undefined (reading 'querySelectorAll')
    at getRows (content.js:125:24)
    at buttonClickHandler (content.js:112:18)
    at HTMLButtonElement.<anonymous> (content.js:89:9)

@GeorgySk
Copy link
Owner Author

GeorgySk commented Nov 1, 2024

Clicking button suddenly broke. Currently, it throws this error:

content.js:125 Uncaught TypeError: Cannot read properties of undefined (reading 'querySelectorAll')
    at getRows (content.js:125:24)
    at buttonClickHandler (content.js:112:18)
    at HTMLButtonElement.<anonymous> (content.js:89:9)

The problem was due to a new element that was added before the table in one of the recent updates. The current way of searching for the table rows should be more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button disappeared after one of the latest updates Use TypeScript?

1 participant