This repository was archived by the owner on Apr 9, 2025. It is now read-only.
add test for CategoryDropdown #280
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this looks a bit silly but hear me out..
I was looking at #278 and wanted to know how much I should trust the fact that all the tests pass on a given PR. So I made a small change to CategoryDropdown (changed "import { data } from 'custom/category'" to "import data from 'custom/category'"). The app failed to start at that point, but all the tests passed.
This test will just catch basic things like that? maybe valuable?
Also Enzyme seems to be preferred way to test react apps these days? Not sure if anyone here has experience