Skip to content
This repository was archived by the owner on Apr 9, 2025. It is now read-only.

Conversation

@neilfulwiler
Copy link
Contributor

@neilfulwiler neilfulwiler commented Mar 12, 2020

  1. fixed a bunch of the travis configuration warnings
  2. added names for the travis jobs (android, ios)
  3. cloned the current ios travis job into ios:prod and ios:dev, ios:prod has a conditional so that it doesn't run on pull requests (which don't have access to the secrets required to sign the build)

@neilfulwiler neilfulwiler changed the title don't create a fake build.json make travis work for PRs Mar 12, 2020
…igning-required build to run on master (not PRs)
@neilfulwiler
Copy link
Contributor Author

@sebastianovide @munroTom does this look reasonable to you?

@sebastianovide
Copy link
Contributor

hi @neilfulwiler I don't know. I really didn't have the time to check it so I don't really know if it will break the build or not.

Just wondering if it is relevant right now in the context of what is more important for Plastic Patrol.

I would say that before improving the build process Plastic Patrol need somebody to get 100% ownership of the whole project.

@neilfulwiler
Copy link
Contributor Author

@sebastianovide not super relevant, it's mostly a way for me to get familiar with Travis. Seeing automated tests pass on PRs is also helpful, though obviously tests are a bit lacking (and again, that isn't the major concern right now).

The point of this (familiarizing myself with Travis, getting the build into a good state), is so that I would be positioned to take 100% ownership of the whole project if that's something that everyone wants/agrees to. Happy to have a more lengthy conversation offline if that would be helpful too?

@neilfulwiler
Copy link
Contributor Author

(those things being important re ownership so that I actually could operate the whole process e2e including CI, build, push, etc.)

@sebastianovide
Copy link
Contributor

that would be great @neilfulwiler . I've talked to Lizzy yesterday and she is happy about it. So Lizzy is owner of Firebase (she needs to remove me as owner), Google Play and Apple App Store. She made you editor of Firebase (you should be able to deploy, if not, tell her to make you owner or to give you a service account for deployments) and she should be in the position of making you admin of the app in both stores.

That means that you should have all what you need to break free from this repo. (just remember to invalidate the old keys so that the current TrevisCIwould not be able to release live from this repo...)

Does it make sense ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants