Skip to content
This repository was archived by the owner on Apr 9, 2025. It is now read-only.

Conversation

@neilfulwiler
Copy link
Contributor

doesn't cost much for us to support google/fb auth, seems more professional to allow 3rd party auth than force email/password sign up.

also restyled the email log in so it doesn't have two stacked dialogs.

the downside however is that you'll be considered a new user if you have previously logged in with an email and then choose to login with your google/fb account (linking accounts looks doable but hard).

before:

Screen Shot 2020-03-12 at 4 02 59 PM

after:

Screen Shot 2020-03-12 at 3 57 52 PM

Screen Shot 2020-03-12 at 3 57 57 PM

@@ -1,27 +0,0 @@
import React from "react";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't doing anything

@munroTom
Copy link
Contributor

I'm not sure if this is configured properly, when I went through the google sign up and then tried to upload a photo I was prompted to sign in again?

It might be because facebook is disabled in the project auth settings?
https://console.firebase.google.com/u/0/project/plastic-patrol-fd3b3/authentication/providers
If that is the case can we also enable it in the dev one? https://console.firebase.google.com/u/0/project/plastic-patrol-dev-722eb/authentication/providers

Another thing to check is that once a user signs in we do manage to pull a display name
Screenshot 2020-03-14 at 10 08 37

@neilfulwiler
Copy link
Contributor Author

neilfulwiler commented Mar 14, 2020 via email

@neilfulwiler neilfulwiler force-pushed the add-fb-google-auth-flows branch from f5e0581 to 6e6b3a3 Compare March 18, 2020 20:38
@neilfulwiler neilfulwiler force-pushed the add-fb-google-auth-flows branch from 6e6b3a3 to 3f17bff Compare March 18, 2020 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants