LinkFinder update. #145
Open
LinkFinder update. #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrrobot1o1
commented
Jan 27, 2024
mrrobot1o1
commented
- Added functionality to support input from javascript URL link file.
- DeprecationWarning: ssl warning fix.
- Updated image for README file.
Image update with file input option.
GerbenJavado
requested changes
Apr 13, 2024
Comment on lines
+340
to
+343
| if os.path.isfile(args.input): | ||
| # Read URLs from the file | ||
| with open(args.input, 'r') as file: | ||
| urls = file.read().splitlines() |
Owner
There was a problem hiding this comment.
This seems to break analyzing JS files locally as the input is not treated as JS but instead split as individual URLs. Prior we would not make any fetch and analyze the content as is. It seems to me analyzing local files is useful so can we revert back to that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.