Update Storage Account Private Endpoint Script#52
Open
kyjones03 wants to merge 8 commits intoGet-Nerdio:mainfrom
Open
Update Storage Account Private Endpoint Script#52kyjones03 wants to merge 8 commits intoGet-Nerdio:mainfrom
kyjones03 wants to merge 8 commits intoGet-Nerdio:mainfrom
Conversation
merging local changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current private endpoint script runs into multiple errors which I have fixed through trial-and-error. The first error is regarding the existing New-AzPrivateDnsVirtualNetworkLink cmdlet as the removed parameter (-RegistrationEnabled) does not exist as part of the cmdlet. Replaced it with -EnableRegistration which defaults to $true for a boolean.
The second error was related to the final step of created the private dns zone group which references $VNetResourceGroup which is in the base subscription context, so we needed to add a new switch and I added outputs to show that we switch back.
I also added some additional verbose outputs and deleted line 84 which was redundant to line 58.