eng: add LaunchDarkly and SafetyAssured RuboCop cops ECOMM-7031 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create unified LaunchDarkly cop supporting both Armageddon and MenuConnector patterns - Create MigrationSafetyAssured cop to flag questionable safety_assured usage - Bump version to 2.1.0 - Update config and entry point
alexbeeken
reviewed
Dec 10, 2025
| module Cop | ||
| module Dutchie | ||
| # Ensures all LaunchDarkly feature flag calls have default values | ||
| # to prevent failures during LaunchDarkly service outages |
alexbeeken
previously approved these changes
Dec 10, 2025
danhealy
previously approved these changes
Dec 10, 2025
- Change from >= 3.1.4 to >= 3.0.6 - Allows MenuConnector (Ruby 3.0.6) to use this gem version - Note: MenuConnector should still plan to upgrade Ruby eventually
danhealy
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements ECOMM-7031 - Add custom RuboCop cops to Dutchie-Style gem
Changes:
LaunchDarkly Defaultscop that supports both:DutchieFeatureFlags.flag(),.context_flag(), etc.ld_client.variation(),MenuConnector::App[:launchdarkly].variation()MigrationSafetyAssuredcop to flag questionablesafety_assuredusage in migrationsRelated tickets:
Test plan
Next steps
After this PR is merged and gem is released (v2.1.0):