New reduction rule: BinaryMatrixFactorization to BicliqueCover#140
Open
c-allergic wants to merge 6 commits intomainfrom
Open
New reduction rule: BinaryMatrixFactorization to BicliqueCover#140c-allergic wants to merge 6 commits intomainfrom
c-allergic wants to merge 6 commits intomainfrom
Conversation
c-allergic
commented
Mar 26, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 93.26% 93.84% +0.58%
==========================================
Files 38 39 +1
Lines 1588 1642 +54
==========================================
+ Hits 1481 1541 +60
+ Misses 107 101 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GiggleLiu
reviewed
Mar 31, 2025
src/rules/BMF_BicliqueCover.jl
Outdated
| Base.:(==)(a::ReductionBMFToBicliqueCover, b::ReductionBMFToBicliqueCover) = a.bicliquecover == b.bicliquecover && a.k == b.k | ||
| target_problem(res::ReductionBMFToBicliqueCover) = res.bicliquecover | ||
|
|
||
| function reduceto(::Type{BicliqueCover}, bmf::BinaryMatrixFactorization) |
Owner
There was a problem hiding this comment.
Suggested change
| function reduceto(::Type{BicliqueCover}, bmf::BinaryMatrixFactorization) | |
| function reduceto(::Type{<:BicliqueCover}, bmf::BinaryMatrixFactorization) |
src/rules/BMF_BicliqueCover.jl
Outdated
| return (B,C) | ||
| end | ||
|
|
||
| function extract_multiple_solutions(res::ReductionBMFToBicliqueCover{Int64}, solution_set::Vector{Vector{Vector{Int64}}}) |
src/rules/BMF_BicliqueCover.jl
Outdated
| end | ||
| end | ||
| end | ||
| return (B,C) |
Owner
There was a problem hiding this comment.
Should return a vector, and convert it back with read_solution. e.g.
Co-authored-by: Jinguo Liu <cacate0129@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems:
findbestmethod could not be applied toBicliqueCoveryet due to the specific configuration shape ofBicliqueCover. Therefore, theextract_solutionfunction and the reduction correctness are not yet tested.