Skip to content

fixed: theme switch bug for login & contributors pages respectively #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehul-m-prajapati merged 2 commits into from
Jul 29, 2025
Merged

fixed: theme switch bug for login & contributors pages respectively #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6616f0f
fixed: theme switch bug for login & contributors pages respectively
Trailblazer09 Jul 27, 2025
8e36ab8
revert link
mehul-m-prajapati Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Footer from "./components/Footer";
import ScrollProgressBar from "./components/ScrollProgressBar";
import { Toaster } from "react-hot-toast";
import Router from "./Routes/Router";
import ThemeWrapper from "./ThemeContext"; // ✅ import your wrapper
import ThemeWrapper from "./context/ThemeContext"; // ✅ import your wrapper

function App() {
return (
Expand Down
2 changes: 1 addition & 1 deletion src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Link } from "react-router-dom";
import { useState, useContext } from "react";
import { ThemeContext } from "../ThemeContext";
import { ThemeContext } from "../context/ThemeContext";

const Navbar: React.FC = () => {
const [isOpen, setIsOpen] = useState<boolean>(false);
Expand Down
0 src/ThemeContext.tsx → src/context/ThemeContext.tsx
View file
Open in desktop
File renamed without changes.
31 changes: 0 additions & 31 deletions src/hooks/useTheme.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { createRoot } from "react-dom/client";
import App from "./App.tsx";
import "./index.css";
import { BrowserRouter } from "react-router-dom";
import ThemeWrapper from "./ThemeContext.tsx";
import ThemeWrapper from "./context/ThemeContext.tsx";

createRoot(document.getElementById("root")!).render(
<StrictMode>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/Contact/Contact.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState, useContext } from "react";
import { Github, Mail, Phone, Send, X, CheckCircle } from "lucide-react";
import { ThemeContext } from "../../ThemeContext";
import type { ThemeContextType } from "../../ThemeContext";
import { ThemeContext } from "../../context/ThemeContext";
import type { ThemeContextType } from "../../context/ThemeContext";

function Contact() {
const [showPopup, setShowPopup] = useState(false);
Expand Down
112 changes: 39 additions & 73 deletions src/pages/Contributors/Contributors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ import {
CircularProgress,
Alert,
} from "@mui/material";
import { FaGithub } from "react-icons/fa"; // GitHub Icon
import axios from "axios";
import { FaGithub } from "react-icons/fa";
import axios from "axios"
import { Link } from "react-router-dom";
import { useTheme } from "../../hooks/useTheme";


interface Contributor {
id: number;
Expand All @@ -24,137 +24,102 @@ interface Contributor {
html_url: string;
}


const ContributorsPage = () => {
const [contributors, setContributors] = useState<Contributor[]>([]);
const [loading, setLoading] = useState<boolean>(true);
const [error, setError] = useState<string | null>(null);
const { theme } = useTheme();

// Theme-based colors
const bgColor = theme === "dark" ? "#1f1f1f" : "#FFFFFF";
const textColor = theme === "dark" ? "#FFFFFF" : "#333333";
const cardBg = theme === "dark" ? "#2a2a2a" : "#FFFFFF";
const borderColor = theme === "dark" ? "#444444" : "#E0E0E0";
const hoverBorder = theme === "dark" ? "#666666" : "#C0C0C0";

// Fetch contributors data from GitHub API
useEffect(() => {
const fetchContributors = async () => {
try {
const response = await axios.get(
"https://api.github.com/repos/mehul-m-prajapati/github_tracker/contributors",
{ withCredentials: false }
{
withCredentials: false,
}
);
setContributors(response.data);
} catch (err) {
setError("Failed to fetch contributors. Please try again later.");
setError("Failed to fetch contributors. Please try again later." + err);
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix error message display issue.

Concatenating an error object to a string will display "[object Object]" instead of meaningful error information.

Apply this diff to properly display error messages:

-        setError("Failed to fetch contributors. Please try again later." + err);
+        setError(`Failed to fetch contributors. Please try again later. ${err instanceof Error ? err.message : String(err)}`);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
setError("Failed to fetch contributors. Please try again later." + err);
setError(`Failed to fetch contributors. Please try again later. ${err instanceof Error ? err.message : String(err)}`);
🤖 Prompt for AI Agents 
In src/pages/Contributors/Contributors.tsx at line 39, the error message
concatenates an error object directly to a string, causing it to display as
"[object Object]". To fix this, convert the error object to a meaningful string
by using err.message or JSON.stringify(err) when setting the error state, so the
displayed message is informative.

} finally {
setLoading(false);
}
};

fetchContributors();
}, []);

// To trigger re-render on theme change (optional)
useEffect(() => {
setContributors((prev) => [...prev]);
}, [theme]);

if (loading) {
return (
<Box sx={{ display: "flex", justifyContent: "center", mt: 4 }}>
<CircularProgress />
</Box>
);
}

if (error) {
return (
<Box sx={{ mt: 4 }}>
<Alert severity="error">{error}</Alert>
</Box>
);
}

return (
<Container
sx={{
mt: 4,
backgroundColor: bgColor,
color: textColor,
minHeight: "100vh",
p: { xs: 2, sm: 4 },
}}
>
<Typography
variant="h4"
align="center"
gutterBottom
sx={{
fontSize: { xs: "1.8rem", sm: "2.2rem" },
fontWeight: "bold",
mb: 3,
}}
>
🤝 GitHub Contributors
</Typography>
<div className="bg-white dark:bg-gray-900 text-black dark:text-white min-h-screen p-4 mt-4">
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Contradicts PR objective: Static styling instead of theme-aware implementation.

The PR aims to fix the theme switch bug on the Contributors page, but this implementation removes theme context usage entirely and uses static Tailwind classes (dark:bg-gray-900, dark:text-white). This approach won't respond to theme changes dynamically since there's no theme context integration.

Apply this diff to integrate proper theme context usage:

+import { useContext } from 'react';
+import { ThemeContext } from '../../context/ThemeContext';

 const ContributorsPage = () => {
+  const themeContext = useContext(ThemeContext);
+  if (!themeContext) return null;
+  const { mode } = themeContext;
+
   const [contributors, setContributors] = useState<Contributor[]>([]);

Then update the wrapper div to use dynamic theming:

-    <div className="bg-white dark:bg-gray-900 text-black dark:text-white min-h-screen p-4 mt-4">
+    <div className={`min-h-screen p-4 mt-4 ${
+      mode === 'dark' 
+        ? 'bg-gray-900 text-white' 
+        : 'bg-white text-black'
+    }`}>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div className="bg-white dark:bg-gray-900 text-black dark:text-white min-h-screen p-4 mt-4">
// at the top of src/pages/Contributors/Contributors.tsx
import React, { useState } from 'react';
import { useContext } from 'react';
import { ThemeContext } from '../../context/ThemeContext';
const ContributorsPage = () => {
const themeContext = useContext(ThemeContext);
if (!themeContext) return null;
const { mode } = themeContext;
const [contributors, setContributors] = useState<Contributor[]>([]);
return (
<div className={`min-h-screen p-4 mt-4 ${
mode === 'dark'
? 'bg-gray-900 text-white'
: 'bg-white text-black'
}`}>
{/* …rest of the Contributors page markup… */}
</div>
);
};
export default ContributorsPage;
🤖 Prompt for AI Agents 
In src/pages/Contributors/Contributors.tsx at line 61, the current div uses
static Tailwind dark mode classes which do not respond to dynamic theme changes.
To fix this, remove the static dark mode classes and instead integrate the theme
context to dynamically apply styles based on the current theme. Update the
wrapper div to conditionally set class names or styles according to the theme
context value so that the page responds correctly to theme switches.

<Container>
<Typography sx={{ pb: 2 }} variant="h4" align="center" gutterBottom>
🤝 GitHub Contributors
</Typography>
<Grid container spacing={4}>
{contributors.map((contributor) => (
<Grid item xs={12} sm={6} md={4} key={contributor.id}>

<Grid container spacing={3}>
{contributors.map((contributor) => (
<Grid item xs={12} sm={6} md={4} key={contributor.id}>
<Link
to={`/user/${contributor.login}`}
style={{ textDecoration: "none" }}
>
<Card
sx={{
textAlign: "center",
backgroundColor: cardBg,
color: textColor,
borderRadius: "12px",
border: `1px solid ${borderColor}`,
p: 2,

borderRadius: "10px",
border: "1px solid #E0E0E0", // Border styling

boxShadow: "0 4px 10px rgba(0,0,0,0.1)",
transition: "transform 0.3s ease-in-out",
"&:hover": {
transform: "scale(1.05)",
transform: "scale(1.05)", // Zoom effect
boxShadow: "0 8px 15px rgba(0,0,0,0.2)",
borderColor: hoverBorder,
borderColor: "#C0C0C0", // Change border color on hover
outlineColor: "#B3B3B3", // Change outline color on hover
},
}}
>
<Avatar
src={contributor.avatar_url}
alt={contributor.login}
sx={{ width: 100, height: 100, mx: "auto", mt: 3 }}
sx={{ width: 100, height: 100, mx: "auto", mb: 2 }}
/>
<CardContent>
<Typography
variant="h6"
sx={{ fontWeight: "bold", color: textColor }}
>
<Typography variant="h6" sx={{ fontWeight: "bold" }}>
{contributor.login}
</Typography>
<Typography variant="body2" sx={{ mt: 1, color: textColor }}>
<Typography variant="body2" color="textSecondary">
{contributor.contributions} Contributions
</Typography>
<Typography variant="body2" sx={{ mt: 2, color: textColor }}>
Thank you for your valuable contributions!
<Typography variant="body2" sx={{ mt: 2 }}>
Thank you for your valuable contributions to our community!
</Typography>
<Box sx={{ mt: 2 }}>
<Button
variant="contained"
startIcon={<FaGithub />}
href={contributor.html_url}
target="_blank"
onClick={(e) => e.stopPropagation()}
sx={{
backgroundColor: "#24292f",
color: "#fff",
fontSize: { xs: "0.75rem", sm: "0.85rem" },
px: 2,
py: 1,
backgroundColor: "#333333",
color: "#FFFFFF",
"&:hover": {
backgroundColor: "#444",
backgroundColor: "#555555", // Custom hover color
},
}}
>
Expand All @@ -163,11 +128,12 @@ const ContributorsPage = () => {
</Box>
</CardContent>
</Card>
</Link>
</Grid>
))}
</Grid>
</Container>
</Link>
</Grid>
))}
</Grid>
</Container>
</div>
);
};

Expand Down
Loading