Merged
Conversation
Rename `EXTRA_CFLAGS` to `DRIVER_CFLAGS` across all build configurations to clarify its specific purpose for driver compilation. Adopt the Kbuild standard `ccflags-y` variable for passing driver-specific compiler flags. This ensures that `DRIVER_CFLAGS` are correctly and idiomatically applied by the kernel build system, improving the robustness and maintainability of the driver's build process. Previously, flags were passed less robustly via the `make` command line. Add a `printk` statement during driver connection to log the effective `DEBUG` and `FIXEDPT_BITS` values. This provides runtime verification that the intended build flags have been correctly applied.
Ensure DRIVER_CFLAGS are passed to nested 'make install' commands during the 'reinstall' and 'reinstall_debug' Makefile targets. This guarantees that any custom or debug-specific flags defined for the driver compilation are consistently applied, preventing potential build configuration mismatches during reinstallation.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
Author
|
✅ Why EXTRA_CFLAGS is no longer recognized Deprecated since 2007: You should be using ccflags-y (or ccflags‑ifdef‑CONFIG_… for conditional flags)—the old EXTRA_CFLAGS was just transitioned under the hood into ccflags-y via a compatibility layer Removed in 2025 (v6.15‑rc1): That compatibility shim was removed completely. Any assignment to EXTRA_CFLAGS is now ignored. External modules or in‑tree code that still try to use it will silently drop your flags or even cause build errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several refinements to the
maccelproject, primarily focusing on clarifying build configurations and updating the CLI version.Key Changes:
EXTRA_CFLAGStoDRIVER_CFLAGS): The compilation flag variableEXTRA_CFLAGShas been consistently renamed toDRIVER_CFLAGSacross theMakefile,PKGBUILD,dkms.conf,driver/Makefile, andinstall.shscripts. This change improves clarity and explicitly indicates that these flags are specific to the kernel module's compilation.maccelkernel module now logs its compilation flags (DEBUGstatus andFIXEDPT_BITS) toKERN_INFOwhen connecting to a device. This enhancement will be highly valuable for verifying driver builds and debugging potential issues related to specific compilation configurations.0.5.6: Themaccel-clipackage and its dependencies have been updated to version0.5.6acrossCargo.toml,Cargo.lock, andPKGBUILD.crates/core/src/persist.rs, removing the unused import forNoAccelParamArgs, which simplifies the persistence logic.Impact:
maccel-cliwith any associated improvements or fixes from version0.5.6.