This repository was archived by the owner on Jan 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 208
Fixed issue with creating multiple AudioComponents when calling Audio… #83
Open
shannah
wants to merge
1
commit into
GoogleCloudPlatform:master
Choose a base branch
from
shannah:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Controller.prepareWithSampleRate: more than once.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
santhoshvaddi
added a commit
to santhoshvaddi/ios-docs-samples
that referenced
this pull request
Apr 19, 2019
timburks
pushed a commit
that referenced
this pull request
Apr 30, 2019
* Initial setup for speech to speech translatin. * Implementation of Speech-to-Speech Translation. * Authentication using service account. * Authentication using firebase functions. * Update README.md * Changes * Add missing file `TokenService.swift`. * Code cleanup and some minor changes for better user experience.. * Change for PR: #83 * Error handling when APIs are disabled and removed intermediate SpeechToSpeech folder. * Add missing google protos folder. * 1. use full language names + codes ("English US (en-US)") 2. Sort languages alphabetically 3. Rename - Synth name - TTS Tech 4. Wavenet default, when it's not available choose Standard 5. Default for voice name - "default" in Grey and it will be empty (chosen by the API automatically) * Update README.md * Minor fix.
timburks
pushed a commit
that referenced
this pull request
Jun 15, 2019
…brary (#115) * Initial setup for speech to speech translatin. * Implementation of Speech-to-Speech Translation. * Authentication using service account. * Authentication using firebase functions. * Update README.md * Changes * Add missing file `TokenService.swift`. * Code cleanup and some minor changes for better user experience.. * Change for PR: #83 * Error handling when APIs are disabled and removed intermediate SpeechToSpeech folder. * Add missing google protos folder. * 1. use full language names + codes ("English US (en-US)") 2. Sort languages alphabetically 3. Rename - Synth name - TTS Tech 4. Wavenet default, when it's not available choose Standard 5. Default for voice name - "default" in Grey and it will be empty (chosen by the API automatically) * Update README.md * Minor fix. * 1. Removed TokenService file 2. Retrieving Token from FirebaseTokenService of authLibrary. * Revert translateParent * Remove TokenService * Updated service classes with FirebaseFunctionTokenProvider.
timburks
pushed a commit
that referenced
this pull request
Jun 24, 2019
…hLibrary (#116) * Initial setup for speech to speech translatin. * Implementation of Speech-to-Speech Translation. * Authentication using service account. * Authentication using firebase functions. * Update README.md * Changes * Add missing file `TokenService.swift`. * Code cleanup and some minor changes for better user experience.. * Change for PR: #83 * Error handling when APIs are disabled and removed intermediate SpeechToSpeech folder. * Add missing google protos folder. * 1. use full language names + codes ("English US (en-US)") 2. Sort languages alphabetically 3. Rename - Synth name - TTS Tech 4. Wavenet default, when it's not available choose Standard 5. Default for voice name - "default" in Grey and it will be empty (chosen by the API automatically) * Update README.md * Minor fix. * 1. Removed TokenService file 2. Retrieving Token from FirebaseTokenService of authLibrary. * Revert translateParent * Remove TokenService * Updated service classes with FirebaseFunctionTokenProvider. * Updated pod file with google-auth-library-swift * 1. Updated Pod file and Removed Tokenreceiver file. 2. Updated StopwatchService files with FirebaseTokenService of authLibrary. * crash fix.
timburks
pushed a commit
that referenced
this pull request
Jul 16, 2019
* Initial setup for speech to speech translatin. * Implementation of Speech-to-Speech Translation. * Authentication using service account. * Authentication using firebase functions. * Update README.md * Changes * Add missing file `TokenService.swift`. * Code cleanup and some minor changes for better user experience.. * Change for PR: #83 * Error handling when APIs are disabled and removed intermediate SpeechToSpeech folder. * Add missing google protos folder. * 1. use full language names + codes ("English US (en-US)") 2. Sort languages alphabetically 3. Rename - Synth name - TTS Tech 4. Wavenet default, when it's not available choose Standard 5. Default for voice name - "default" in Grey and it will be empty (chosen by the API automatically) * Update README.md * Minor fix. * 1. Removed TokenService file 2. Retrieving Token from FirebaseTokenService of authLibrary. * Revert translateParent * Remove TokenService * Updated service classes with FirebaseFunctionTokenProvider. * Updated pod file with google-auth-library-swift * 1. Updated Pod file and Removed Tokenreceiver file. 2. Updated StopwatchService files with FirebaseTokenService of authLibrary. * Initial implementation of FCM * crash fix. * Updated the files with FCM functionality. * Integrated FCM into Speech to Speech Sample. * #Removed FCMTokenProvider file from the project #Implemented Token Call from FCMTokenProvider of AuthLibrary. #Code Refactoring and Enhancement. * Update pod file. * Update README.md
timburks
pushed a commit
that referenced
this pull request
Jul 23, 2019
* Initial setup for speech to speech translatin. * Implementation of Speech-to-Speech Translation. * Authentication using service account. * Authentication using firebase functions. * Update README.md * Changes * Add missing file `TokenService.swift`. * Code cleanup and some minor changes for better user experience.. * Change for PR: #83 * Error handling when APIs are disabled and removed intermediate SpeechToSpeech folder. * Add missing google protos folder. * 1. use full language names + codes ("English US (en-US)") 2. Sort languages alphabetically 3. Rename - Synth name - TTS Tech 4. Wavenet default, when it's not available choose Standard 5. Default for voice name - "default" in Grey and it will be empty (chosen by the API automatically) * Update README.md * Minor fix. * 1. Removed TokenService file 2. Retrieving Token from FirebaseTokenService of authLibrary. * Revert translateParent * Remove TokenService * Updated service classes with FirebaseFunctionTokenProvider. * Updated pod file with google-auth-library-swift * 1. Updated Pod file and Removed Tokenreceiver file. 2. Updated StopwatchService files with FirebaseTokenService of authLibrary. * Initial implementation of FCM * crash fix. * Updated the files with FCM functionality. * Integrated FCM into Speech to Speech Sample. * #Removed FCMTokenProvider file from the project #Implemented Token Call from FCMTokenProvider of AuthLibrary. #Code Refactoring and Enhancement. * Update pod file. * Update README.md * Update README
timburks
pushed a commit
that referenced
this pull request
Aug 16, 2019
…eader` role. (#122) * Initial setup for speech to speech translatin. * Implementation of Speech-to-Speech Translation. * Authentication using service account. * Authentication using firebase functions. * Update README.md * Changes * Add missing file `TokenService.swift`. * Code cleanup and some minor changes for better user experience.. * Change for PR: #83 * Error handling when APIs are disabled and removed intermediate SpeechToSpeech folder. * Add missing google protos folder. * 1. use full language names + codes ("English US (en-US)") 2. Sort languages alphabetically 3. Rename - Synth name - TTS Tech 4. Wavenet default, when it's not available choose Standard 5. Default for voice name - "default" in Grey and it will be empty (chosen by the API automatically) * Update README.md * Minor fix. * 1. Removed TokenService file 2. Retrieving Token from FirebaseTokenService of authLibrary. * Revert translateParent * Remove TokenService * Updated service classes with FirebaseFunctionTokenProvider. * Updated pod file with google-auth-library-swift * 1. Updated Pod file and Removed Tokenreceiver file. 2. Updated StopwatchService files with FirebaseTokenService of authLibrary. * Initial implementation of FCM * crash fix. * Updated the files with FCM functionality. * Integrated FCM into Speech to Speech Sample. * #Removed FCMTokenProvider file from the project #Implemented Token Call from FCMTokenProvider of AuthLibrary. #Code Refactoring and Enhancement. * Update pod file. * Update README.md * Update README * - Update README with `Dailogflow API Reader` role. - Fixed knowledge connector issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Controller.prepareWithSampleRate: more than once.
Before applying this patch, you'll find that speech recognition is unreliable if you stop and restart the AudioController. This is because it keeps creating a new AudioComponent without disposing the previous one.