Skip to content

fix(netconf): Stop the UDP mitigation after the fixed Kernel version. #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MrHohn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(netconf): Stop the UDP mitigation after the fixed Kernel version. #462

MrHohn wants to merge 1 commit into from

Conversation

@MrHohn
Copy link
Collaborator

@MrHohn MrHohn commented Aug 26, 2025 •
edited
Loading

@google-oss-prow
Copy link
Contributor

google-oss-prow bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jingyuanliang
jingyuanliang reviewed Aug 26, 2025
View reviewed changes
pkg/controllers/netconf/network_config_controller.go Outdated
glog.Infof("Kernel version is impacted by a known issue (start version: %v). Including an IP rule to exempt UDP traffic.", brokenLocalUDPKernelVersionStart)
// The known issue was fixed since linux kernel 6.6.94.
if kernelVersion.AtLeast(version.MustParseGeneric(brokenLocalUDPKernelVersionStart)) &&
!kernelVersion.AtLeast(version.MustParseGeneric(brokenLocalUDPKernelVersionEnd)) {
Copy link
Member

@jingyuanliang jingyuanliang Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://google.github.io/styleguide/go/decisions#indentation-confusion

Copy link
Collaborator Author

@MrHohn MrHohn Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@MrHohn MrHohn marked this pull request as draft August 26, 2025 20:03
@MrHohn
Copy link
Collaborator Author

MrHohn commented Aug 26, 2025

Converted to draft as I realized we may need to handle for version higher than 6.6.X.

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Aug 27, 2025
@MrHohn MrHohn marked this pull request as ready for review August 27, 2025 22:08
@MrHohn
Copy link
Collaborator Author

MrHohn commented Aug 27, 2025

Okay, converted to version ranges instead as per the discussion yesterday. PTAL thanks!

@MrHohn
Copy link
Collaborator Author

MrHohn commented Aug 27, 2025

Meanwhile, putting a hold so I can actually verify this on a live cluster.
/hold

@jingyuanliang
Copy link
Member

jingyuanliang commented Aug 27, 2025

Hmm it looks like all official 6.8.x releases are not impacted: last released https://lore.kernel.org/lkml/2024053036-matron-confess-13e0@gregkh/ 6.8.12 on 30 May 2024; breakage introduced https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d8f84a9bc7c4e07fdc4edc00f9e868b8db974ccb in master on 2024-09-10. It must be Ubuntu's cherry pick having brought it in.

@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Nov 19, 2025
@MrHohn MrHohn changed the title feat(netconf): Stop installing UDP mitigation rule for newer kernels fix(netconf): Stop the UDP mitigation after the fixed Kernel version. Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingyuanliang jingyuanliang jingyuanliang left review comments

Assignees

@jingyuanliang jingyuanliang

Labels

approved do-not-merge/hold size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MrHohn @jingyuanliang