Draft
Conversation
…gger may have already been closed.
TestStart unit test flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
windowsEventLogger.Close()is called within thecancelfunction when either of the two sub-agent processes exits. These sub-agent processes are spawned as separate goroutines. The cancel function logs any error messages before callingClose()on the Windows event logger. The crash occurs when one subprocess exits and closes the eventLogger while the other subprocess is still attempting to access it to log errors.The fix to it is to handle windows event logger creation and closing inside main.go function. The entire UAP plugin is essentially an RPC server, the windows event logger is now created before the server starts listening for requests (blocking), and closed when server stops serving.
Related issue
b/465497407
How has this been tested?
UAP windows unit tests should not flake anymore
Checklist: