Skip to content

feat: Add --use-random-row for custom-query row validations#1666

Merged
nj1973 merged 12 commits intodevelopfrom
1448-random-row-sampling-custom-queries
Feb 6, 2026
Merged

feat: Add --use-random-row for custom-query row validations#1666
nj1973 merged 12 commits intodevelopfrom
1448-random-row-sampling-custom-queries

Conversation

@nj1973
Copy link
Collaborator

@nj1973 nj1973 commented Feb 5, 2026

Description of changes

This PR adds the options --use-random-row and --random-row-batch-size for custom-query row validations.

This PR also restricts the tested Python version to 3.11 because 3.9 and 3.10 are no longer available on the python-multi image. We'll need to prioritise the Ibis upgrade issue soon.

There are a good number of test file edits which were me fixing a typo, use_randow_row to use_random_row.

Issues to be closed

Closes #1448

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973 nj1973 linked an issue Feb 5, 2026 that may be closed by this pull request
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 5, 2026
@nj1973 nj1973 requested a review from cofin February 5, 2026 21:38
Copy link
Contributor

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
@nj1973 nj1973 merged commit 1654b21 into develop Feb 6, 2026
5 of 6 checks passed
@nj1973 nj1973 deleted the 1448-random-row-sampling-custom-queries branch February 6, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random row sampling does not work with custom queries

2 participants