Verify AppIdentityService signatures against all valid certificates#51
Verify AppIdentityService signatures against all valid certificates#51
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@jmaurice FYI |
|
The code LGTM, but I'm not happy with the fact that the |
chingor13
left a comment
There was a problem hiding this comment.
Looks fine to me assuming that AppIdentityService::signForApp is doing a basic openssl signature.
This could also speed up the verification by not having to make a synchronous API call, but could also use more of your allotted CPU.
This PR is based on #50, but added some commits for the test to pass.