Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Comments

Verify AppIdentityService signatures against all valid certificates#51

Merged
tmatsuo merged 3 commits intomasterfrom
jmaurice-pr
Nov 20, 2017
Merged

Verify AppIdentityService signatures against all valid certificates#51
tmatsuo merged 3 commits intomasterfrom
jmaurice-pr

Conversation

@tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Nov 20, 2017

This PR is based on #50, but added some commits for the test to pass.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Nov 20, 2017

@jmaurice FYI

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Nov 20, 2017

The code LGTM, but I'm not happy with the fact that the appengine-plugin doesn't have tests (and some other cosmetic things of the original files).

@tmatsuo tmatsuo requested a review from chingor13 November 20, 2017 19:07
Copy link
Member

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me assuming that AppIdentityService::signForApp is doing a basic openssl signature.

This could also speed up the verification by not having to make a synchronous API call, but could also use more of your allotted CPU.

@tmatsuo tmatsuo merged commit 4edb98c into master Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants