Fix FormControl implementation for Input component LTS version #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Input component documentation for the LTS version (v3.2.2) was showing incomplete FormControl implementation in the reactive forms sandbox example. While the TypeScript code correctly showed
itemFormCtrl = new FormControl(""), the HTML template was displaying[value]="value"instead of the proper FormControl binding.Closes #2809
Root Cause
The issue was in the
AngularReactiveSerializerwhere theReactiveComponentsarray only included new version component names (goab-input,goab-textarea, etc.) but not the old version names (goa-input,goa-textarea, etc.).When the serializer processes components for the LTS version:
GoabInput→goa-input(old version)modifyPropsmethod checks if the component is inReactiveComponentsarraygoab-inputwas listed,goa-inputcomponents weren't recognized as reactiveSolution
Updated the
ReactiveComponentsarray inAngularReactiveSerializer.tsto include both old and new version component names:Results
Before (LTS version)
itemFormCtrl = new FormControl("")<goa-input name="item" [value]="value" width="20ch">After (LTS version)
itemFormCtrl = new FormControl("")<goa-input name="item" [formControl]="itemFormCtrl" [value]="itemFormCtrl.value" width="20ch">Current version (v4.0.0+) - Unaffected
formControlName="item"Testing
- ✅ Built successfully with no TypeScript errors
- ✅ LTS version now shows proper FormControl binding in reactive forms
- ✅ Current version functionality remains unchanged
- ✅ All other reactive components (textarea, dropdown, etc.) will also benefit from this fix
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.