-
Notifications
You must be signed in to change notification settings - Fork 10
feat(#1908): Add Linear Progress documentation and examples #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1c5f96d to
d78121b
Compare
twjeffery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @willcodeforcoffee
A few small issues I see that need to be adjusted. I'll list them below, let me know if you have any questions and/or want to discuss:
- temporary notification "New" badge now bleeding off right of side menu
-
linear progress indicator should have "New" badge
-
the code snippet for the 3rd example (Automatically increasing progress) is not showing a show more button for some reason, so you can't see all the code. My only clue to why is perhaps because you are not using the sandbox in the same way as other pages?
twjeffery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willcodeforcoffee Looks good to me!


This PR adds the documentation for the new Linear Progress control.
Originally all of the documentation for the Circular Progress controls was simply labelled "Progress Indicator", which is confusing when there are two indicators now. So all "Progress Indicator" mentions were renamed to "Circular Progress Indicator" and left beside the "Linear Progress Indicator" for discoverability, and, consistency.
Note: This PR is currently not building because the main repo cannot publish to npm at the moment.
When that is resolved:
Related story: