fix: display phone number for unknown group chat senders #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In group conversations, the author first name is computed by using the author's full name, however, this fails when the author is null (which is the case for numbers not added as a contact). This leads to notifications from any number not in your contacts in a group conversation show up as being from "null", which is wrong.
Solution
I've set the author's first name to be the phone number of the sender as a fallback, which fixes notifications from this number. The screenshots below show the visual change before & after this PR.
Before:

After:

The unknown number ending in 8 now properly displays itself as the sender of a given message in notifications.