[#1] CHORE: CI 테스트용 스키마 생성 및 Flyway 비활성화#79
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
CI 환경에서 테스트 실행 시 DB 스키마/테이블을 Hibernate로 생성하도록 하고, Flyway를 비활성화하여 CI 테스트 안정성을 높이려는 PR입니다.
Changes:
- GitHub Actions 테스트 단계에서
ddl-auto=create설정 추가 - GitHub Actions 테스트 단계에서 Flyway 비활성화 설정 추가
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+113
to
+114
| SPRING_JPA_HIBERNATE_DDL_AUTO: create | ||
| SPRING_FLYWAY_ENABLED: false |
There was a problem hiding this comment.
In GitHub Actions YAML, unquoted false is parsed as a boolean by the YAML parser. While Actions typically coerces env values to strings, quoting here avoids any edge-case coercion issues and makes it explicit that the process env var should be the string "false" (same for other non-obvious strings). Consider setting SPRING_FLYWAY_ENABLED: 'false' (and optionally quoting create too for consistency).
Suggested change
| SPRING_JPA_HIBERNATE_DDL_AUTO: create | |
| SPRING_FLYWAY_ENABLED: false | |
| SPRING_JPA_HIBERNATE_DDL_AUTO: 'create' | |
| SPRING_FLYWAY_ENABLED: 'false' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue ✨
버그 해결 💊