Don't rebuild the path multiple times or check file on disk #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Gregwar any news on this buddy? |
Contributor
Author
|
@Gregwar had a chance to take a look? 😄 |
Owner
|
Hello, |
garygreen
force-pushed
the
performance
branch
from
e8d06cf to
129db6d
Compare
Contributor
Author
|
@Gregwar Hello! PR has been updated 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the path to the image e.g. 3/d/4/a/g/4 was being generated multiple times due to multiple calls to
getCacheFile. This PR fixes that