-
Notifications
You must be signed in to change notification settings - Fork 447
feat: enable datasource support for gcs storage #7258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: StandingMan <jmtangcs@gmail.com>
|
Hi @Standing-Man, thank you for your contribution! However, I’d prefer to use |
You mean there already support |
No, the data export and import CLI tools don't support these backends. You can refer to the metadata import CLI to see how cli::common::ObjectStoreConfig supports multiple backends. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Google Cloud Storage (GCS) datasource support to GreptimeDB, enabling users to export data to GCS storage backends. The implementation follows the existing patterns established for S3 and OSS storage backends.
- Adds a new GCS module with configuration validation and backend builder functions
- Integrates GCS into the table options validation system
- Extends the CLI export command with GCS-specific parameters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/common/datasource/src/object_store/gcs.rs | New module implementing GCS backend builder with support for endpoint, credentials, ACL, and storage class configuration |
| src/common/datasource/src/object_store.rs | Integrates GCS module exports and adds GCS_SCHEMA handling in backend builder |
| src/table/src/requests.rs | Adds GCS options to table option validation logic |
| src/cli/src/data/export.rs | Adds GCS-related command-line parameters (bucket, root, endpoint, credential, ACL, storage class) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Standing-Man Do you have time to address this comment? If not, I think we can close it right now or make it as draft. Thank you. |
For now, I’ve converted it to a draft. I’ll continue working on this PR when I have more time. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
gcsstorage.gcs.PR Checklist
Please convert it to a draft if some of the following conditions are not met.