fix(procedure): update procedure state correctly during execution and on failure #7376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
docs-not-required
WenyXu
force-pushed
the
fix/procedure-runner
branch
from
8ab5f59 to
618e926
Compare
… on failure Signed-off-by: WenyXu <wenymedia@gmail.com>
WenyXu
force-pushed
the
fix/procedure-runner
branch
from
618e926 to
f6cf674
Compare
fengjiachun
approved these changes
Dec 10, 2025
MichaelScofield
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR fixes two issues in the procedure runner:
Procedure state not updated to Running after retry: When a procedure transitions from Retrying state back to execution (via Status::Executing or Status::Suspended), the procedure state was not being updated to Running. This could cause incorrect state reporting and potential issues with procedure monitoring.
Incorrect rollback state for procedures that don't support rollback: When a procedure fails but does not support rollback (i.e., rollback_supported() returns false), the runner was still setting the state to PrepareRollback. Now it correctly sets the state to Failed for such procedures.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.