Skip to content

Fix: Store updated voltage phase angles in data collection on updateData in dynamic_simulation_full_y #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ta7mid wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: Store updated voltage phase angles in data collection on updateData in dynamic_simulation_full_y #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af19e94
fix(dynamic_simulation_full_y_module): update voltage angles on `upda…
ta7mid Nov 28, 2025
4f3ec3c
fix: BUS_VANG_CURRENT should be in degrees
ta7mid Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/applications/modules/dynamic_simulation_full_y/dsf_components.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* Licensed under modified BSD License. A copy of this license can be found
* in the LICENSE file in the top level directory of this distribution.
*/
#include <cmath>
#include <complex>
#include <vector>
#include <iostream>

Expand All @@ -12,6 +14,11 @@
#include "lvshbl.hpp"
#include "gridpack/utilities/string_utils.hpp"

namespace {

const double pi = 4.0*std::atan(1.0);

} // namespace

/**
* Simple constructor
Expand Down Expand Up @@ -891,7 +898,6 @@ void gridpack::dynamic_simulation::DSFullBus::load(
data->getValue(BUS_AREA, &p_area);
p_zone = 1;
data->getValue(BUS_ZONE, &p_zone);
double pi = 4.0*atan(1.0);
p_angle = p_angle*pi/180.0;

p_shunt = true;
Expand Down Expand Up @@ -1300,11 +1306,13 @@ void gridpack::dynamic_simulation::DSFullBus::updateData(
int i;
std::string name;
gridpack::ComplexType voltage = getComplexVoltage();
double rV = real(voltage);
double iV = imag(voltage);
rV = sqrt(rV*rV+iV*iV);
if (!data->setValue(BUS_VMAG_CURRENT, rV)) {
data->addValue(BUS_VMAG_CURRENT, rV);
auto vmag = std::abs(voltage);
if (!data->setValue(BUS_VMAG_CURRENT, vmag)) {
data->addValue(BUS_VMAG_CURRENT, vmag);
}
auto vang = std::arg(voltage)*180.0/pi;
if (!data->setValue(BUS_VANG_CURRENT, vang)) {
data->addValue(BUS_VANG_CURRENT, vang);
}
for (i=0; i<p_ngen; i++) {
if (data->getValue(GENERATOR_MODEL,&name,i)) {
Expand All @@ -1325,8 +1333,8 @@ void gridpack::dynamic_simulation::DSFullBus::updateData(
lcnt++;
} else {
double pl_current,ql_current;
pl_current = rV*rV*p_gload[i];
ql_current = -rV*rV*p_bload[i];
pl_current = vmag*vmag*p_gload[i];
ql_current = -vmag*vmag*p_bload[i];
if(p_bscatterinjload_flag_compensateY) {
pl_current -= p_scatterinjload_p;
ql_current -= p_scatterinjload_q;
Expand Down Expand Up @@ -1478,7 +1486,6 @@ void gridpack::dynamic_simulation::DSFullBus::LoadExtendedCmplBus(
}

//load data for LOAD_BUS
double pi = 4.0*atan(1.0);

//p_shunt = true;
//p_shunt = p_shunt && data->getValue(LOAD_BSS, &p_shunt_bs);
Expand Down Expand Up @@ -1930,7 +1937,6 @@ void gridpack::dynamic_simulation::DSFullBus::computeBusVolFrequency( double tim
{
const double dFREQ_SYS = 60.0;
const double dTf = 0.1;
const double pi = 4.0*atan(1.0);
const double dw0 = 2.0*dFREQ_SYS*pi;

double dstatex, dstatex1, ddx1, ddx2, dva_old, dva;
Expand Down Expand Up @@ -3452,7 +3458,6 @@ void gridpack::dynamic_simulation::DSFullBranch::setYBus(void)
// printf ("from %d-> to %d: p_phase_shift = %f, a = %f+%fi\n", bus1->getOriginalIndex(), bus2->getOriginalIndex(), p_phase_shift, real(a), imag(a) );
// }
//p_theta = bus1->getPhase() - bus2->getPhase();
double pi = 4.0*atan(1.0);
p_theta = (bus1->getPhase() - bus2->getPhase());
//printf("p_phase_shift: %12.6f\n",p_phase_shift);
//printf("p_theta: %12.6f\n",p_theta);
Expand Down Expand Up @@ -3528,7 +3533,6 @@ void gridpack::dynamic_simulation::DSFullBranch::load(
double rvar;
int ivar;
bool lvar;
double pi = 4.0*atan(1.0);
p_active = false;
ok = data->getValue(CASE_SBASE, &p_sbase);
int idx;
Expand Down Expand Up @@ -3615,7 +3619,6 @@ void gridpack::dynamic_simulation::DSFullBranch::load(
void gridpack::dynamic_simulation::DSFullBranch::evaluateBranchFlow()
{
int i;
double pi = 4.0*atan(1.0);

gridpack::dynamic_simulation::DSFullBus *bus1 =
dynamic_cast<gridpack::dynamic_simulation::DSFullBus*>(getBus1().get());
Expand Down
1 change: 1 addition & 0 deletions src/parser/variable_defs/bus_defs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
* type: real float
*/
#define BUS_VOLTAGE_ANG "BUS_VOLTAGE_ANG"
#define BUS_VANG_CURRENT "BUS_VANG_CURRENT"

/**
* Bus voltage frequency at current time
Expand Down