chore: migrate to Turborepo + Biome #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ESLint + Prettier with Biome for linting and formatting. Add Turborepo for build orchestration and caching. Changes: - Add biome.json configs (root + sdk package) - Add turbo.json with lint, typecheck, build, test tasks - Update CI workflow to use Turborepo with GitHub Actions cache - Remove .prettierrc, .prettierignore, eslint.config.mjs - Reformat all source files with Biome - Add .turbo to .gitignore Benefits: - Faster linting (Biome is ~10-100x faster than ESLint) - Unified tool for lint + format (less config, fewer deps) - Turborepo caching speeds up CI and local dev - Simpler toolchain to maintain
- Fix node:buffer imports (use node: protocol) - Fix regex control characters with biome-ignore comments - Add explicit types to implicit any let declarations - Fix React Button type and useEffect dependencies - Fix non-null assertions with proper guards
- docs: fix tsconfig include path and add Layout props interface - example: update imports to use workspace SDK, add component prop types - sdk: add type assertions for currency literals and getAddresses returns - sdk: add curveType/hashType to ETH_MSG signing requests in tests - sdk: use public getFwVersion() getter instead of private property
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Use unrolled loop pattern for multi-line comments to avoid exponential backtracking on malicious inputs like ',/**//**//**/' patterns.
Remove hardcoded pnpm version 9 from workflows to use the packageManager field from package.json (pnpm@10.6.2) instead.
Remove custom lineWidth (240) and indentStyle from biome.json to use defaults. Reformat all files to 80-char line width.
Convert all indentation from tabs to 2-space indent for consistency.
netbonus
requested review from
hmrkx and
yilmazbahadir
and removed request for
yilmazbahadir
commit: |
netbonus
force-pushed
the
feat/turborepo-biome
branch
from
0d3cab8 to
42356dd
Compare
- Add @gridplus/btc package with Biome linting - Add btc xpub utilities to SDK - Update root scripts to include @gridplus/btc in CI - Add @types/node to docs package - Fix e2e args passthrough in CI
netbonus
force-pushed
the
feat/turborepo-biome
branch
from
d4c0b8e to
21785cc
Compare
Merged feat/btc-package from dev, preserving turborepo/biome config: - Keep turbo scripts in root package.json - Keep biome linting in @gridplus/btc package - Keep Number.parseInt/Number.parseFloat (biome preference) - Keep explicit null checks in getAllXpubs
Turborepo sandboxes environment variables by default. Add passThroughEnv to the e2e task to allow CI-defined variables (DEVICE_ID, PASSWORD, etc.) to reach the test runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added:
biome.json- Root Biome config with linting and formatting rulespackages/sdk/biome.json- SDK-specific Biome config extending rootturbo.json- Turborepo task definitions for lint, typecheck, build, testRemoved:
.prettierrc,.prettierignore- Replaced by Biome formatterpackages/sdk/eslint.config.mjs- Replaced by Biome linterModified:
.github/workflows/build-test.yml- Use Turborepo with GitHub Actions cache.gitignore- Add.turbocache directorypackage.json- Add turbo and @biomejs/biome deps, update scriptsBenefits
Test plan
pnpm run lint- passes (6 warnings for unused params, acceptable)pnpm run typecheck- passespnpm run build- passespnpm test- passes (152 tests)