Experiment with update #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 2a89832 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon Oct 27 09:56:16 2025 +0100 Fixed GPU_TX_MARKER test commit c240128 Merge: 10160bc e38d006 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri Oct 24 18:29:55 2025 +0200 Merge remote-tracking branch 'upstream/main' into nvtx_ranges commit 10160bc Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri Oct 24 18:27:58 2025 +0200 Fix instrumentation for copies commit d14093c Author: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch> Date: Mon Oct 6 16:16:43 2025 +0200 Make pre-commit happy commit 68942a3 Merge: a3063e5 b415f62 Author: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch> Date: Tue Sep 30 17:11:35 2025 +0200 Merge remote-tracking branch 'upstream/main' into nvtx_ranges commit a3063e5 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Sep 23 18:03:26 2025 +0200 Working version of nvtx markers with allocations commit 6788b97 Author: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch> Date: Tue Sep 23 13:42:41 2025 +0200 Updated functions commit 455ad38 Author: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch> Date: Tue Sep 23 13:20:51 2025 +0200 Added marker on allocations as well commit 80ce99c Author: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch> Date: Wed Aug 20 19:02:36 2025 +0300 Avoid profiling tasklets commit 0314386 Author: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch> Date: Wed Aug 20 19:02:28 2025 +0300 Fix get_latest_report_path in case there's no report commit aad5e87 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Wed Aug 20 10:05:16 2025 +0200 Remove import of deleted file commit a3ff00e Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 18:16:11 2025 +0200 Revert "Improved GPU Copy (spcl#1976)" This reverts commit bc83c47. commit ea5f6ff Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 18:14:35 2025 +0200 Make format happy commit b1ea9af Merge: bbc1faf aabbe48 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 19:12:43 2025 +0300 Merge branch 'main' into nvtx_ranges commit bbc1faf Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 18:07:12 2025 +0200 Format a bit better with dace.instrument commit eea658f Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 18:04:54 2025 +0200 Fixes in gpu_tx_markers.py commit 2f43f7a Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 18:04:43 2025 +0200 Remove instrument_sdfg commit 0fdb4df Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 17:28:57 2025 +0200 Small refactoring of if statements in gpu_tx_markers.py commit 73c52bf Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 17:26:02 2025 +0200 Added on_sdfg_init/exit_begin/end functions commit ff70f2f Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 16:32:34 2025 +0200 Replaced is with == commit 3d626e0 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 16:31:04 2025 +0200 Fix local and global streams commit 209860d Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 16:27:04 2025 +0200 Improve _is_sdfg_in_device_code commit bc83c47 Author: Philip Müller <147368808+philip-paul-mueller@users.noreply.github.com> Date: Mon Jun 2 15:58:08 2025 +0200 Improved GPU Copy (spcl#1976) Before some 2D copies (especially if they had FORTRAN order) were turned into Maps, see [issue#1953](spcl#1953). This PR modifies the code generator in such a way that such copies are now handled. There is some legacy stuff that should also be looked at. --------- Co-authored-by: Philip Mueller <philip.paul.mueller@bluemain.ch> Co-authored-by: Tal Ben-Nun <tbennun@gmail.com> commit df99571 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Tue Aug 19 17:34:12 2025 +0300 Apply suggestion from @tbennun Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com> commit da00f21 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 19 17:49:47 2025 +0200 Avoid pushing rocTX markers before initializing HIP since it doesn't work commit a39308b Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 16 15:13:31 2025 +0200 Fix on_copy and on_scope for GPU_TX_MARKERS commit 2d554fa Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Thu May 15 15:20:05 2025 +0200 Removed preprocessor checks by properly placing ranges in NestedSDFGs and small fixes for CPU wrapper includes commit 5937a15 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Wed May 14 11:33:02 2025 +0200 Refactored a bit GPUTXMarkerProvider commit 9e8ec9e Author: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch> Date: Wed May 14 10:52:26 2025 +0200 Addressed PR comments for checking is the instrumentation is enabled commit c3f1932 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 12 17:29:30 2025 +0200 Small fixes and cleanups commit 366721f Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 12 17:23:21 2025 +0200 Fix order of imports in gpu_events.py commit 8ea4327 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 12 17:04:56 2025 +0200 Add markers for different SDFGs and states commit 22b372e Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 12 09:45:20 2025 +0200 Revert changes in GPU_Event provider commit e5adaef Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 12 09:34:34 2025 +0200 Allow building with HIP even if rocTX is not found commit b30f4a2 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 9 17:20:34 2025 +0200 Fix formatting commit 747f357 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 9 17:14:17 2025 +0200 Made test NVTX agnostic and updated documentation commit 646ca90 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 9 17:05:10 2025 +0200 Use same checks for enabling roctx as CMake commit c28036b Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 9 17:00:19 2025 +0200 Fix compilation for AMD gpu commit 855304d Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Thu May 8 11:58:00 2025 +0200 Fix library names commit 9df4f73 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Thu May 8 11:36:29 2025 +0200 Trying to use roctx commit a55aeb7 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Wed May 7 17:58:37 2025 +0200 Make formatting happy commit a8bcadf Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Wed May 7 17:50:10 2025 +0200 Renamed NVTX to GPU_TX_MARKERS and added note for AMD GPUs commit 7337233 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 17:30:35 2025 +0200 Changed nvtxRangePushA to nvtxRangePush commit 74c9117 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 17:23:42 2025 +0200 Fix copyright and GPU test commit 989bc32 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 17:12:59 2025 +0200 Make formatter happy commit 4f57297 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 17:09:58 2025 +0200 Remove NVTX markers from LIKWID since LIKWID has its own markers commit a4d2ff8 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 17:08:08 2025 +0200 Improved NVTX markers in likwid commit 1e71171 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 15:42:13 2025 +0200 Update NVTX Provider imports commit 438090f Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 15:41:56 2025 +0200 Update documentation commit 89b7864 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 15:41:48 2025 +0200 Small fix of whiteline in framecode commit ef5355b Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 15:38:02 2025 +0200 Refactored NVTX Instrumentation provider constructor and test for expected code commit bbf1d32 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Mon May 5 15:37:16 2025 +0200 Inherit LIKWID_GPU Instrumentation provider from NVTX as well commit 90b50ac Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 2 18:29:07 2025 +0200 Make GPUEventProvider inherit from NVTXProvider to enable the NVTX markers by default with it commit c584255 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 2 18:01:31 2025 +0200 Updated documentation commit 04836fb Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 2 18:01:21 2025 +0200 Moved the printing of NVTX range push and pop inside the NVTXProvider commit f5240b2 Author: Ioannis Magkanaris <iomagkanaris@gmail.com> Date: Fri May 2 17:25:04 2025 +0200 Added NVTX range in CPU wrapper for GPU kernel
commit c069546 Merge: 41902c3 408a481 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Tue Nov 4 11:22:14 2025 +0100 Merge remote-tracking branch 'spcl/main' into make_construct_args_public commit 41902c3 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 16:01:26 2025 +0100 Fixed a bug. commit 65725f9 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 15:15:03 2025 +0100 This should be enough for bug compatibility. commit daf90e9 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 12:58:25 2025 +0100 Updated the thing a bit more. commit 2ddabbd Merge: 4da0c4e b44aeb0 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 12:54:19 2025 +0100 Merge remote-tracking branch 'spcl/main' into make_construct_args_public commit 4da0c4e Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 12:53:48 2025 +0100 Made some additional check. commit 69960ce Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 12:00:30 2025 +0100 Forgot to do this. commit 6e1a9ff Merge: c1214fa 1bf2173 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 11:25:46 2025 +0100 Merge remote-tracking branch 'spcl/main' into make_construct_args_public commit c1214fa Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 09:50:41 2025 +0100 Updated the tests and made it clear that you can not return a scalar from an SDFG. commit 9397a23 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 09:40:29 2025 +0100 Implemented the proper handling of tuples of size one. commit e8d909e Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 09:30:48 2025 +0100 Removed that stupid sclar return value feature that CAN NOT WORK. However, I saw that it also, under the hood sometimes tests if the argument is a pyobject. Since that thing is a pointer it is possible and I implemented it for that. But it was again not implemented properly, since for the case when the return value is passed as a regular argument, it was not checking that, only for managed return values. commit ab110d2 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 09:24:45 2025 +0100 Updated the description. commit 899b2a0 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 09:24:32 2025 +0100 Fixed some old stuff. commit 7f17e13 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 09:08:49 2025 +0100 Fixed a bug, but in a way I do not like. commit c2c1116 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 08:40:47 2025 +0100 Removed a missleading comment. commit ded5df8 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 08:04:38 2025 +0100 Made some refactoring to remove some strange DaCe behaviour. commit b029828 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 08:02:28 2025 +0100 Fixed an issue in safe_call commit b09c9fc Author: Philip Mueller <philip.mueller@cscs.ch> Date: Fri Oct 31 07:17:36 2025 +0100 Included the first bunch of Tal's changes. commit e138b06 Author: Philip Mueller <philip.mueller@cscs.ch> Date: Thu Oct 30 15:12:23 2025 +0100 Made the 'passed as positional and named argument'-error more explicit. commit f901a3d Author: Philip Mueller <philip.mueller@cscs.ch> Date: Thu Oct 30 15:05:00 2025 +0100 Fixed a bug in a unit test. Due to the refactoring the case that a variable is passed once as positional and as named argument is not detected and asserted. This test however, passed `a` always as positional argument and if `symbolic` is `True` also as named argument. commit 767260d Author: Philip Mueller <philip.mueller@cscs.ch> Date: Thu Oct 30 14:19:44 2025 +0100 Clarified a comment. commit 2b8123a Author: Philip Mueller <philip.mueller@cscs.ch> Date: Thu Oct 30 13:56:20 2025 +0100 Made the construct argumt vector function publich and also refactored some things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.