-
Notifications
You must be signed in to change notification settings - Fork 54
build: Dropping python 3.10 support #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
build: Dropping python 3.10 support #2326
Conversation
Drop 3.10 testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see references to 3.10 in
-
pyproject.toml: the section[tool.ruff]has atarget-version -
.devcontainer/Dockerfile -
ci/Dockerfile - the jupyter notebooks under
docs/user/next/workshop(not sure if all of those need to change)
Those I believe are "last run version", so irrelevant. |
|
This is passing checks now. I turned on |
romanc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
havogt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but we need to update our deployment environment first, therefore I need to block this PR for a bit.
All good, merge when ready. |
Description
Requirements