feat: implement game details for launching declared exe and args#15
Merged
feat: implement game details for launching declared exe and args#15
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements support for fetching and using game-specific launch details (executable path and arguments) from the IndieGala API. Instead of relying solely on automatic executable detection, the launcher can now use server-provided configuration for Windows games.
Key changes:
- Adds API client functionality to fetch game details including exe path, arguments, and working directory
- Updates launch command to prioritize server-declared executables over local search
- Integrates game details fetching into install and info commands
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| auth/product.go | New file implementing API calls to fetch and cache game launch details (exe path, args, cwd) |
| launch/launch.go | Adds FindDeclaredExecutable function to retrieve and process server-declared game executables for Windows builds |
| cmd_launch.go | Updates launch logic to attempt fetching declared executable from server before falling back to local search |
| cmd_install.go | Adds game details fetching during installation to pre-cache launch information |
| cmd_info.go | Displays game details (exe path, args, cwd) when showing game information |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12