Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom configuration directory paths through a new --config-path command-line flag. This allows users to specify an alternative location for the application's configuration files instead of using the default directory.
Key Changes:
- Added
--config-pathflag to allow users to specify a custom configuration directory - Renamed
testConfigDirtooverrideConfigDirto better reflect its dual purpose (testing and custom config) - Updated all test files to use the renamed variable
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| main.go | Added configPath flag, import for auth package, and logic to set custom config directory using absolute paths |
| go.mod | Moved github.com/google/shlex from indirect to direct dependency |
| auth/config.go | Renamed testConfigDir to overrideConfigDir and added OverrideConfigDir function for public use |
| auth/session_test.go | Updated variable references from testConfigDir to overrideConfigDir |
| auth/userinfo_test.go | Updated variable references from testConfigDir to overrideConfigDir |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13