fix: use child process when launching games#9
Merged
Conversation
… freecarnival is killed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances game launching by implementing proper child process management with context support and changes the default install behavior on macOS to prefer native builds over Windows builds.
Key Changes:
- Added context-aware process management with graceful termination on cancellation
- Changed macOS install default from Windows to native Mac builds
- Removed macOS
.appbundle-specific launching in favor of direct binary execution
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| launch/launch.go | Implements context-aware process launching with process group management and graceful/forceful termination support |
| cmd_launch.go | Integrates context cancellation handling for clean Ctrl+C behavior during game execution |
| cmd_install.go | Updates default OS selection to prefer macOS builds on darwin systems instead of Windows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also now installs mac games on macOS by default, instead of Windows games. Option is still there if the user wants to download a Windows version.