[Draft] Added version check, annotation tools, viewport (all screens) capture, no copy to clipboard parameter and more#99
Open
msmafra wants to merge 3 commits intoGustash:mainfrom
Open
[Draft] Added version check, annotation tools, viewport (all screens) capture, no copy to clipboard parameter and more#99msmafra wants to merge 3 commits intoGustash:mainfrom
msmafra wants to merge 3 commits intoGustash:mainfrom
Conversation
Added the short and long arguments -v and --version to check the current version of Hyprshot.
…kticks "`cmd`" in favor of $(cmd). put variables declaration and attribution in separated lines etc.; adding annotation tool option to auto choose between satty (default) and swappy; show cursor option*; viewport option (all monitors capture); Probably helps with Gustash#66 Gustash#17 Gustash#102 * at least on my machine, even without passing -c to grim it captures mouse cursors. I imagine is related to NVIDIA drivers and /or my hyprland configuration related to NVIDIA.
Author
|
Added [Draft] to the title since it needs some testing and I'll make more changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the begining it was just to add -v and --version to check the current version of Hyprshot.", but decided to make more changes after. So now...
Making shellcheck happy adding and moving things to a main function, removing some deprecated things like backticks “cmd” in favor of "$(cmd)", putting variables declaration and attribution in separated lines, setting variables types when possible and other changes. Made some variables less verbose narrowing their captured values with jq.
New features:
Mind you that at least currently wayshot has problems to capture all screens. (tested on Hyprland 0.48.0)
Probably helps with
#17
#25
#37
#66
#102
*at least on my machine, even without passing "-c" to grim it captures mouse cursors some times. I imagine is related to NVIDIA drivers and /or my Hyprland configuration related to NVIDIA.
Need some more diversity in testing. I tested mostly on my machine using Fedora Workstation 41 and a bit on CachyOS.