Fix crashes when viewing directory with sort=stack#128
Merged
noahp merged 5 commits intoHBehrens:masterfrom Dec 3, 2025
Merged
Fix crashes when viewing directory with sort=stack#128noahp merged 5 commits intoHBehrens:masterfrom
noahp merged 5 commits intoHBehrens:masterfrom
Conversation
Fix crashes when we get a mix of None and int in sum(), because symbol_traverse() uses none_sum() in one branch and sum() in other.
traverse_filter_wrapper() changes 0 to "", but we later use none_sum() to sum the result, which will crash when trying to add str to int. Instead use symbol_traverse() directly and only convert 0 to "" after none_sum().
Collaborator
|
thanks! i added a test, i'll merge when it finishes testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes crashes where code attempts to sum integers with None or an empty string "" when viewing a source directory with the url argument sort=stack_asc or sort=stack_desc.
How to reproduce: