Skip to content

Replace custom icons + fonts with unicode glyphs#137

Open
noahp wants to merge 1 commit intomasterfrom
noahp/remove-custom-icons-fonts
Open

Replace custom icons + fonts with unicode glyphs#137
noahp wants to merge 1 commit intomasterfrom
noahp/remove-custom-icons-fonts

Conversation

@noahp
Copy link
Collaborator

@noahp noahp commented Dec 3, 2025

They add some 110kB to the distributions (~168kB vs 55kB for .whl).

Replace with unicode glyphs, and bonus- add a favicon 🔍

Copilot AI review requested due to automatic review settings December 3, 2025 18:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces distribution size by ~110kB by replacing custom icon SVG files and Glyphicons font files with Unicode characters. The changes include adding a favicon emoji and updating CSS to use pseudo-elements with Unicode glyphs instead of background images.

Key changes:

  • Remove custom SVG icon files (Folder, Document, Method, Field icons)
  • Remove Glyphicons font files (.woff, .woff2, .ttf, .svg, .eot)
  • Replace icon styling with CSS pseudo-elements using Unicode characters
  • Add magnifying glass emoji favicon and brand icon

Reviewed changes

Copilot reviewed 5 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pyproject.toml CRITICAL BUG: Updated include paths with incorrect indentation causing TOML syntax error
puncover/templates/base.html.jinja Added inline SVG favicon with 🔍 emoji and updated navbar brand
puncover/static/icons/*.svg Removed custom icon files (Folder, FolderOpen, Document, Method, Field)
puncover/static/fonts/* Removed Glyphicons font files to reduce distribution size
puncover/static/css/style.css Refactored icon classes to use Unicode glyphs via ::before pseudo-elements; potential compatibility issues with mathematical characters
README.md Updated title with 🔍 emoji for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

They add some 110kB to the distributions (~168kB vs 55kB for .whl).

Replace with unicode glyphs, and bonus- add a favicon 🔍
@noahp noahp force-pushed the noahp/remove-custom-icons-fonts branch from 26b20f2 to 81745be Compare December 3, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant