Replace custom icons + fonts with unicode glyphs#137
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces distribution size by ~110kB by replacing custom icon SVG files and Glyphicons font files with Unicode characters. The changes include adding a favicon emoji and updating CSS to use pseudo-elements with Unicode glyphs instead of background images.
Key changes:
- Remove custom SVG icon files (Folder, Document, Method, Field icons)
- Remove Glyphicons font files (.woff, .woff2, .ttf, .svg, .eot)
- Replace icon styling with CSS pseudo-elements using Unicode characters
- Add magnifying glass emoji favicon and brand icon
Reviewed changes
Copilot reviewed 5 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | CRITICAL BUG: Updated include paths with incorrect indentation causing TOML syntax error |
| puncover/templates/base.html.jinja | Added inline SVG favicon with 🔍 emoji and updated navbar brand |
| puncover/static/icons/*.svg | Removed custom icon files (Folder, FolderOpen, Document, Method, Field) |
| puncover/static/fonts/* | Removed Glyphicons font files to reduce distribution size |
| puncover/static/css/style.css | Refactored icon classes to use Unicode glyphs via ::before pseudo-elements; potential compatibility issues with mathematical characters |
| README.md | Updated title with 🔍 emoji for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
They add some 110kB to the distributions (~168kB vs 55kB for .whl). Replace with unicode glyphs, and bonus- add a favicon 🔍
26b20f2 to
81745be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They add some 110kB to the distributions (~168kB vs 55kB for .whl).
Replace with unicode glyphs, and bonus- add a favicon 🔍