Skip to content

Only count assembly for size when no size present#22

Open
samfriedman wants to merge 1 commit intoHBehrens:masterfrom
samfriedman:dont-clobber-size
Open

Only count assembly for size when no size present#22
samfriedman wants to merge 1 commit intoHBehrens:masterfrom
samfriedman:dont-clobber-size

Conversation

@samfriedman
Copy link

Counting assembly bytes doesn't work properly for constant data in the .text section, which causes underreporting of sizes. The actual size reported by nm is present and accurate, so we prefer that and only count assembly bytes when nm doesn't give us a size.

@HBehrens
Copy link
Owner

This is absolutely the right thing to do, thank you @samfriedman ! Unfortunately, this change won't merge cleanly anymore. Unless you are volunteering to do so, I will rebase your change on top of master and write a test for it to prevent future regressions before merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants