Only count assembly for size when no size present#22
Open
samfriedman wants to merge 1 commit intoHBehrens:masterfrom
Open
Only count assembly for size when no size present#22samfriedman wants to merge 1 commit intoHBehrens:masterfrom
samfriedman wants to merge 1 commit intoHBehrens:masterfrom
Conversation
Owner
|
This is absolutely the right thing to do, thank you @samfriedman ! Unfortunately, this change won't merge cleanly anymore. Unless you are volunteering to do so, I will rebase your change on top of master and write a test for it to prevent future regressions before merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counting assembly bytes doesn't work properly for constant data in the .text section, which causes underreporting of sizes. The actual size reported by nm is present and accurate, so we prefer that and only count assembly bytes when nm doesn't give us a size.