Open
Conversation
and some paths, where the current directory was added befor the file path (only seen with windows paths)
Owner
|
Thank you for providing some more real-world data into the mix and providing a matching implementation, @ribsey 💪 @noahp I haven't look at the code in a while, do you know if this part does have tests already? With all of this regex shenanigans, I am worried we will (one day) introduce a regression during the attempt to add more features. If yes, adding the examples provided would be awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a library with windows file paths and some of them had even the current working directory during the build added in front of the file path, like this:
D:\\stack\\targets\\ST\\STM32F0/HW-Abstraction.c:122or this:
D:\\some\\other\\path\\D:\\stack\\targets\\ST\\STM32F0/HW-Abstraction.c:122So with the new regex and the backslash to slash replacement, these paths get parsed as well.