Fix inconsistent empty postfix handling #6094
Open
+3
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
cacheinit.cmakefile is used, the library sets an OS-specific Debug build library postfix if none is provided by the user. However, the way this check is done means that if a user manually provides an empty string value for the postfix, it will be detected the same as an unprovided postfix and replaced. This is likely to lead to confusion, since the user manually specified an empty postfix but instead receives the default postfixes.This updates the check to distinguish between a user-provided empty postfix and an undefined postfix.
I also removed an old postfix check from an examples counterpart of the
HDF_DIR_PATHSmacro inHDF5Examples/config/HDFMacros.cmake, since it appears that this was copied and became out of date with the modern version of the macro inHDFMacros.cmake.Resolves a secondary issues brought up in #6087