Skip to content

Fix: make major_name match plan filename#7

Merged
kowyo merged 4 commits intoHITSZ-OpenAuto:mainfrom
kowyo-bot:fix/plan-filenames-match-major-name
Feb 1, 2026
Merged

Fix: make major_name match plan filename#7
kowyo merged 4 commits intoHITSZ-OpenAuto:mainfrom
kowyo-bot:fix/plan-filenames-match-major-name

Conversation

@kowyo-bot
Copy link
Contributor

@kowyo-bot kowyo-bot commented Feb 1, 2026

This fixes cases where [info].major_name in plan TOMLs did not match the <major_name> part in the filename (year_本_<major_name>.toml).

  • Updated [info].major_name in 14 affected files to match the filename
  • Kept filenames unchanged (no renames in the final state)

@gemini-code-assist
Copy link

Summary of Changes

Hello @kowyo-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving data consistency and preventing potential filesystem issues by synchronizing the naming conventions of TOML plan files with their internal major_name fields. The changes ensure that the external file representation accurately reflects its internal content, which is crucial for data integrity and system compatibility.

Highlights

  • File Renaming for Consistency: Renamed 14 TOML plan files to ensure their filenames (specifically the <major_name> part) accurately match the [info].major_name value contained within each file.
  • Path Separator Resolution: Addressed a potential path separator issue by replacing a forward slash ('/') with a full-width forward slash ('/') in one major_name within a filename, maintaining consistency while preventing filesystem conflicts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix mismatches between plan TOML filenames and their internal major_name values. While most files are correctly renamed, an inconsistency remains in src/hoa_majors/data/plans/2023_本_建筑类/工科试验班(智慧人居类).toml. The filename uses a full-width slash (), but the major_name inside uses a standard slash (/). The pull request description indicates this was meant to be fixed, but the file content was not updated. Updating the major_name to use the full-width slash would resolve this inconsistency.

@kowyo-bot kowyo-bot changed the title Fix plan filename/major_name mismatches Fix: make major_name match plan filename Feb 1, 2026
@kowyo kowyo merged commit 74f703a into HITSZ-OpenAuto:main Feb 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants