Skip to content

Quality of life improvements #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tdealtry wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Quality of life improvements #30

tdealtry wants to merge 11 commits into from

Conversation

@tdealtry
Copy link
Collaborator

@tdealtry tdealtry commented Mar 4, 2024 •
edited
Loading

  • Make detector a required argument of flower_with_bonsai.C
  • New option to get NPMTs from WCSimRootGeom
  • Default option to get PMT dark rate from WCSimRootOptions (can override with macro argument)
  • New CheckNearestNeighbours() method for testing distances in new geometries
  • Ensure the nearest neighbours file you're reading in has the right number of PMTs in it
  • Add way to get fNEff & fNEff2 (required for tuning)
  • Add new enumeration for new HK detector geometry (tune will come in a new PR)
  • flower_with_bonsai.C now produces a TTree with reconstruction results
  • flower_with_bonsai.C safely handles BONSAI exceptions

tdealtry added 11 commits March 4, 2024 17:56
@tdealtry
Make detector required argument; option to get npmts from WCSimRootGe…
28705da 
…om; default option to get PMT dark rate from WCSimRootOptions (can override with macro argument); new CheckNearestNeighbours() method for testing distances in new geometries
@tdealtry
Add way to get fNEff & fNEff2 (required for tuning)
453f7e1
@tdealtry
Add new enumeration for new HK detector geometry (still need to add t…
fe22ebb 
…he tune)
@tdealtry
Fix the mode number of neighbours calculation. Fix some printouts
17937dd
@tdealtry
Add TTree output
0d4a050
@tdealtry
Handle BONSAI exceptions
80632a5
@tdealtry
Add average event times for benchmarking
ac110b4
@tdealtry
Warning for if the true track isn't found
3ac5940
@tdealtry
Ensure the nearest neighbours file you're reading in has the right nu…
15cfc3b 
…mber of PMTs in it
@tdealtry
Update new geom top/bottom distance
62ac478
@tdealtry
Useful macro for tuning. Under construction
09a9eed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tdealtry