Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does several things:
weighted_balanced_truncation::Boolkeyword argument for choosing the weighted balanced truncation method in model reduction.VPMR_cal. (It's really weird to only keep theNhere since the de la Vallée-Poussin approximation does needThe newly added weighted balanced truncation method for model reduction in the current implementation is the same as the VPMR implementation. The advantage may be only obvious when using some other weight function(the Gramians with using Heaviside weight function is the same with solving continuous Lyapunov equation), but to take that advantage we may need to compute the weighted integral$I_w(x,y)=\int_{-\infty}^{+\infty}e^{-(x+y)t}w(t)w^*(t)dt$ , which is heavily dependent on the choice of weight function. So we might provide a way to specify the weight function and compute the integral to obtain the Gramians.