Fixes "TypeError" for all http 404 responses #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, any `404` response from mailgun would cause a `TypeError: exception class/object expected` to be thrown from the mailgun gem. Now they return nil.
melcher
force-pushed
the
not_found_exception
branch
from
966d46a to
309e46d
Compare
Collaborator
Collaborator
|
@hairihan do you have any opinion on the topic? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, any
404response from mailgun would cause aTypeError: exception class/object expectedto be thrown from the mailgun gem.The previous behavior is that 404 should return a nil response instead of throwing an exception. This re-introduces that behavior (with specs), so that only errors that respond to the 'handle' method will be re-raised.