feat(dynamic-transaction-model): token version #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raul-oliveira
commented
Oct 28, 2025
raul-oliveira
commented
- Token version in the create token tx
- bump version to 0.12.0
raul-oliveira
force-pushed
the
feat/token_version_support
branch
from
587979c to
e2672b7
Compare
r4mmer
approved these changes
Oct 28, 2025
| # for this special tx, its own hash is used as the created token uid. We're artificially | ||
| # creating the tokens list here | ||
| self.tokens = [] | ||
| self.token_version: TokenVersion = TokenVersion.DEPOSIT |
Member
There was a problem hiding this comment.
Shouldn't we create a method to set the token version?
Contributor
Author
There was a problem hiding this comment.
The token version is been set in the create_from_struct similar to the other props of the tx
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
glevco
approved these changes
Oct 28, 2025
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.