Skip to content

Conversation

@AdityaDwiNugroho
Copy link
Contributor

Implements comprehensive logging functionality (#3):

  • Add log_message() function with timestamp formatting
  • Implement log rotation when file exceeds 1MB
  • Add ENABLE_LOGGING and LOG_PRIVACY config options
  • Create 'log' command with --tail and --clear options
  • Add logging to create, start, and stop operations
  • Include privacy mode to avoid logging sensitive data
  • Update README with logging documentation

All acceptance criteria met:

  • Logging can be enabled/disabled via config
  • Log file created in ~/.config/nm-hotspot/
  • All major actions are logged with timestamps
  • Log viewing and clearing commands implemented
  • Log rotation functionality included
  • Privacy-conscious with LOG_PRIVACY option

Implements comprehensive logging functionality (HiddenKeyDev#3):
- Add log_message() function with timestamp formatting
- Implement log rotation when file exceeds 1MB
- Add ENABLE_LOGGING and LOG_PRIVACY config options
- Create 'log' command with --tail and --clear options
- Add logging to create, start, and stop operations
- Include privacy mode to avoid logging sensitive data
- Update README with logging documentation

All acceptance criteria met:
- Logging can be enabled/disabled via config
- Log file created in ~/.config/nm-hotspot/
- All major actions are logged with timestamps
- Log viewing and clearing commands implemented
- Log rotation functionality included
- Privacy-conscious with LOG_PRIVACY option
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening your first pull request in nm-hotspot-cli, @AdityaDwiNugroho.

A maintainer will review your contribution. Here's what happens next:

  1. Automated checks will run
  2. A maintainer will review your code
  3. Changes may be requested
  4. Once approved, your PR will be merged

Please ensure:

  • Your code follows the project style guidelines
  • You have tested your changes
  • Documentation is updated if needed

Thank you for contributing.

@HiddenKeyDev
Copy link
Owner

HiddenKeyDev commented Oct 6, 2025

Thanks for the contribution! Could you please address the ShellCheck errors before we proceed with the review?

Add 'true' command before redirection to comply with ShellCheck
best practices. This fixes the warning about redirection without
a command in the log clearing functionality.
@HiddenKeyDev
Copy link
Owner

LGTM! Great work on implementing the logging system. Merging now.

@HiddenKeyDev HiddenKeyDev merged commit 42da4da into HiddenKeyDev:main Oct 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants