Fix audio input selection problems on Application.cpp refactor #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGro
reviewed
Feb 21, 2025
| #include <QAudio> | ||
| #include <QString> | ||
|
|
||
| #define HIFI_AUDIO_DEVICE_INFO_DEFAULT_DEVICE_NAME "default " |
There was a problem hiding this comment.
Little question about this: Why put strings like this one in the header file and then read them in the implementation? With interface/src/scripting/AudioDevices.cpp I would think the reason is that you use the same string multiple times. But here it is only used once.
Owner
There was a problem hiding this comment.
I think 74 had a theory at one point that these strings weren't initialized in time or something like that, but that wasn't the problem, so this is just harmless.
HifiExperiments
merged commit 5d0fcce
into
HifiExperiments:application
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.