Improve start procedure for captive portal web server #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch will stop running corresponding code on the module-level of `webserver.py`, which should be avoided. Instead, it will invoke the code at runtime, after activating the WiFi in AP mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
this patch aims to improve the behavior reported at GH-42, that, when the device is booting, but is not able to activate the WiFi for whatever reason, the program croaks.
This improvement aims to handle this situation more gracefully. A Zip archive can be acquired using 1.
With kind regards,
Andreas.
Footnotes
https://codeload.github.com/hiveeyes/Hiverize-FiPy-Firmware/zip/refs/heads/amo/fix-network-on-boot ↩