Skip to content

Conversation

@arikalon1
Copy link
Collaborator

@arikalon1 arikalon1 commented Jan 9, 2026

Summary by CodeRabbit

  • Documentation

    • Added a new Azure (MCP) toolset entry to the Built-in Toolsets guide, expanding available toolset resources.
  • Chores

    • Updated the MariaDB MCP add-on image to a newer patch release (1.0.5) to incorporate upstream fixes and improvements.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Arik Alon <alon.arik@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 9, 2026

CLA Not Signed

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Added a new "Azure (MCP)" toolset entry to the built-in toolsets documentation index and bumped the MariaDB MCP add-on image tag in Helm values from 1.0.3 to 1.0.5.

Changes

Cohort / File(s) Summary
Documentation — Built-in Toolsets
docs/data-sources/builtin-toolsets/index.md
Added new "Azure (MCP)" entry linking to azure-mcp.md.
Helm — MCP add-ons values
helm/holmes/values.yaml
Updated mcpAddons.mariadb.image tag from mariadb-http-mcp-minimal:1.0.3 to mariadb-http-mcp-minimal:1.0.5.

Sequence Diagram(s)

(omitted — changes are documentation and a simple image tag update)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • moshemorad
  • Avi-Robusta
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an Azure (MCP) toolset entry to the builtin toolsets documentation index.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94c8786 and 52c8b37.

📒 Files selected for processing (1)
  • helm/holmes/values.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Docker image ready for e9bf6d0 (built in 5m 28s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:e9bf6d0
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:e9bf6d0 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:e9bf6d0
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:e9bf6d0

Patch Helm values in one line (choose the chart you use):

HolmesGPT chart:

helm upgrade --install holmesgpt ./helm/holmes \
  --set registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set image=holmes-dev:e9bf6d0

Robusta wrapper chart:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set holmes.image=holmes-dev:e9bf6d0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

📂 Previous Runs

📜 Run @ 94c8786 (#20852124890)

✅ Results of HolmesGPT evals

Automatically triggered by commit 94c8786 on branch azure-mcp-index-link

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
09_crashpod 29.4s ↓13% 5 12 $0.1550
101_loki_historical_logs_pod_deleted 38.7s ↓26% 6 13 $0.1737
111_pod_names_contain_service 38.0s ±0% 7 16 $0.1756
12_job_crashing 53.0s ↑12% 9 19 $0.2352
162_get_runbooks 54.8s ↑14% 8 20 $0.2436
176_network_policy_blocking_traffic_no_runbooks 46.4s ↑18% 8 17 $0.2022
24_misconfigured_pvc 37.7s ±0% 7 18 $0.1784
43_current_datetime_from_prompt 3.1s ±0% 1 $0.0618
61_exact_match_counting 10.7s ±0% 3 3 $0.0859
Total 34.7s avg 6.0 avg 14.8 avg $1.5113

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'azure-mcp-index-link'

Status: Success - 31 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)

✅ Results of HolmesGPT evals

Automatically triggered by commit bcdb5b8 on branch azure-mcp-index-link

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
09_crashpod 41.0s ↑27% 7 14 $0.1280
101_loki_historical_logs_pod_deleted 79.1s ↑39% 11 28 $0.2887
111_pod_names_contain_service 43.1s ↑14% 7 15 $0.1242
12_job_crashing 51.9s ±0% 9 20 $0.1715
162_get_runbooks 57.4s ±0% 7 20 $0.1831
176_network_policy_blocking_traffic_no_runbooks 41.8s ±0% 6 14 $0.1252
24_misconfigured_pvc 37.0s ±0% 7 16 $0.1255
43_current_datetime_from_prompt 3.3s ±0% 1 $0.0085
61_exact_match_counting 12.4s ↑14% 3 3 $0.0326
Total 40.8s avg 6.4 avg 16.2 avg $1.1874

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'azure-mcp-index-link'

Status: Success - 9 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)
📖 Legend
Icon Meaning
The test was successful
The test was skipped
⚠️ The test failed but is known to be flaky or known to fail
🚧 The test had a setup failure (not a code regression)
🔧 The test failed due to mock data issues (not a code regression)
🚫 The test was throttled by API rate limits/overload
The test failed and should be fixed before merging the PR
🔄 Re-run evals manually

⚠️ Warning: /eval comments always run using the workflow from master, not from this PR branch. If you modified the GitHub Action (e.g., added secrets or env vars), those changes won't take effect.

To test workflow changes, use the GitHub CLI or Actions UI instead:

gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref azure-mcp-index-link -f markers=regression -f filter=

Option 1: Comment on this PR with /eval:

/eval
markers: regression

Or with more options (one per line):

/eval
model: gpt-4o
markers: regression
filter: 09_crashpod
iterations: 5

Run evals on a different branch (e.g., master) for comparison:

/eval
branch: master
markers: regression
Option Description
model Model(s) to test (default: same as automatic runs)
markers Pytest markers (no default - runs all tests!)
filter Pytest -k filter (use /list to see valid eval names)
iterations Number of runs, max 10
branch Run evals on a different branch (for cross-branch comparison)

Quick re-run: Use /rerun to re-run the most recent /eval on this PR with the same parameters.

Option 2: Trigger via GitHub Actions UI → "Run workflow"

🏷️ Valid markers

benchmark, chain-of-causation, compaction, context_window, coralogix, counting, database, datadog, datetime, easy, elasticsearch, embeds, frontend, grafana-dashboard, hard, kafka, kubernetes, leaked-information, logs, loki, medium, metrics, network, newrelic, no-cicd, numerical, one-test, port-forward, prometheus, question-answer, regression, runbooks, slackbot, storage, toolset-limitation, traces, transparency


Commands: /eval · /rerun · /list

CLI: gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref azure-mcp-index-link -f markers=regression -f filter=

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for holmes-docs ready!

Name Link
🔨 Latest commit 52c8b37
🔍 Latest deploy log https://app.netlify.com/projects/holmes-docs/deploys/6962016e763b9600077760c7
😎 Deploy Preview https://deploy-preview-1347--holmes-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@arikalon1 arikalon1 enabled auto-merge (squash) January 10, 2026 07:36
@arikalon1 arikalon1 merged commit 35276a8 into master Jan 10, 2026
13 of 17 checks passed
@arikalon1 arikalon1 deleted the azure-mcp-index-link branch January 10, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants