cask uninstall: opt-in quit/signal on upgrade/reinstall #21130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobuntu
changed the title
Member
|
This is great! I'll give it a proper look through and test a bit later today or tomorrow. But thanks for looking at this @toobuntu |
bevanjkay
reviewed
Nov 25, 2025
bevanjkay
approved these changes
Nov 26, 2025
toobuntu
force-pushed
the
feature/cask-dsl/quit-signal-on-upgrade
branch
from
59c7df6 to
e9686e1
Compare
carlocab
approved these changes
Nov 27, 2025
Library/Homebrew/test/support/fixtures/cask/Casks/with-uninstall-quit-on-upgrade.rb
Outdated
Show resolved
Hide resolved
Allow casks to opt into running uninstall quit/signal during brew upgrade/reinstall (default is to skip them) via on_upgrade. Add fixtures, tests, and update docs. Implements Homebrew#17247
toobuntu
force-pushed
the
feature/cask-dsl/quit-signal-on-upgrade
branch
from
e9686e1 to
3536f2e
Compare
Contributor
Author
|
Rebased and updated: |
Teach UninstallMethodsOrder about on_upgrade metadata key, and add spec cases covering it. - Ignore metadata for ordering checks. - Flag on_upgrade when none of its symbols match uninstall directives, and autocorrect when other directives exist. - Warn without autocorrecting when on_upgrade symbols are invalid.
toobuntu
force-pushed
the
feature/cask-dsl/quit-signal-on-upgrade
branch
from
3536f2e to
45cdd3a
Compare
MikeMcQuaid
approved these changes
Dec 10, 2025
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks great, thanks @toobuntu, nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Implements #17247 by letting casks opt into running uninstall quit/signal during
brew upgradeandbrew reinstall(default is to skip them) via anon_upgrademetadata key for uninstall stanzas of the formon_upgrade: :quit,on_upgrade: :signal, oron_upgrade: [:quit, :signal].Adds fixtures, tests, updates docs, and teaches
UninstallMethodsOrderto validate the metadata key and ignore it when checking uninstall method ordering. Default behavior remains unchanged unless a cask opts in.