[13.0][password_security] : Multiple corrections to add missing translations in the fr.po file #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add translations of zxcvbn library feedback - Return suggestion feedback in _check_password_rules method (only warnings were returned)
…ll translation in fr.po file
MarineGCH
force-pushed
the
13.0-1-password_security-add-translation-file
branch
from
2ebcaa1 to
6595800
Compare
MarineGCH
force-pushed
the
13.0-1-password_security-add-translation-file
branch
2 times, most recently
from
7c494be to
d7d3549
Compare
- Modification of the widget to wait for all translations to be loaded - Other corrections to take into account the configuration of the password rules in the gauge message
MarineGCH
force-pushed
the
13.0-1-password_security-add-translation-file
branch
from
39c98d8 to
3fe198b
Compare
Collaborator
Author
|
@Theo-Drappier @Warlocklogan @Max-282 @Creamaster @PBarraco pour info |
Max-282
reviewed
Oct 27, 2022
|
Une petite description tout en haut pour expliquer pourquoi tu fais tout ça ? Pour pouvoir s'en rappeler dans un futur plus ou moins éloigné. |
MarineGCH
force-pushed
the
13.0-1-password_security-add-translation-file
branch
from
263a7ca to
772fa8c
Compare
Collaborator
Author
Yes tu as raison, c'est fait. |
MarineGCH
force-pushed
the
13.0-1-password_security-add-translation-file
branch
from
269fe6f to
ddb6c7f
Compare
MarineGCH
force-pushed
the
13.0-1-password_security-add-translation-file
branch
from
1765ad0 to
1d853f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted versions: 13.0
When hovering over the gauge indicating the strength of the password, a message containing the recommendations is displayed (number of lower case letters, uppercase letters, etc.).
This issue allows: