support for new CentOS/PHP versions #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Simons <dave@inuits.eu>
Signed-off-by: Dave Simons <dave@inuits.eu>
Signed-off-by: Dave Simons <dave@inuits.eu>
Signed-off-by: Dave Simons <dave@inuits.eu>
This reverts commit 5fc8a61.
This reverts commit 0e8a3d0.
Signed-off-by: Dave Simons <dave@inuits.eu>
…sing errors for lines with no right hand value Signed-off-by: sabot <sabot@inuits.eu>
…nd resubmit Signed-off-by: sabot <sabot@inuits.eu>
…errors due to missing = characters. I replaced the use of augeas with a template for the apc.ini file Signed-off-by: sabot <sabot@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
Signed-off-by: Patrick Van Brussel <patrick@inuits.eu>
refs #13449
Signed-off-by: Frank Maes <fmaes@inuits.be>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
The variable $php_version has never been used when it was used in params.pp. So all setups used $php_version = '5.3' because it was default value which couldn't be overloaded. Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: honza <honza@inuits.eu>
Signed-off-by: honza <honza@inuits.eu>
Signed-off-by: honza <honza@inuits.eu>
Signed-off-by: honza <honza@inuits.eu>
Signed-off-by: honza <honza@inuits.eu>
Signed-off-by: honza <honza@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
The commit looks like I changed all the lines but it's caused by ^M at the ends of lines. They were removed. The problem with compatibility was fixed by quoting the strings. Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Signed-off-by: Pavel Pulec <kayn@inuits.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintenance this puppet module internally but now we would like to publish for the rest of world. This pull request brings a lot of changes which were necessary for newer CentOS and PHP versions.
We also get rid of augeas so it solves the issue #3
I am aware of outdated README.md.