Fix the update flag (now including test)#57
Open
mfabinski wants to merge 4 commits intoHoverHell:masterfrom
Open
Fix the update flag (now including test)#57mfabinski wants to merge 4 commits intoHoverHell:masterfrom
mfabinski wants to merge 4 commits intoHoverHell:masterfrom
Conversation
Closed
HoverHell
requested changes
Oct 21, 2016
| try: # py3 | ||
| from mock import patch, MagicMock | ||
| except ImportError: # py2 | ||
| from unittest import mock |
Owner
There was a problem hiding this comment.
Note that in this case you don't seem to have a patch function which is used later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #52 by adding the specific exception handler in the inner exception handling block.
Now the update flag works as supposed:
Thanks to @rachmadaniHaryono for adding tests for the fix continue flag