Re-arrange for SmartThings IDE github integration#1
Open
loverso wants to merge 2 commits intoHubitatCommunity:masterfrom
Open
Re-arrange for SmartThings IDE github integration#1loverso wants to merge 2 commits intoHubitatCommunity:masterfrom
loverso wants to merge 2 commits intoHubitatCommunity:masterfrom
Conversation
Author
|
I wrote:
This is incorrect, as it causes the package name to not be what the code expects when it tries to add a new virtual device. I found this out last night when I tried to share a device from Hubitat=>ST and the device didn't up in ST, and there was an error in the live logging. I'm about to update this to remove "SmartThings" from each "name:" and to rename the files to remove that from the name. |
string from the name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rearranged the files and updated them so that this repo works in the SmartThings IDE github integration.
The basic change is to move the files from SmartThings/DeviceTypes to devicetypes/shackrat.
Each source has to be in a subdirectory named with ".src" and the filenames need to be all lowercase.
Each "name:" in the definition needs to match the filename (so I had to add "SmartThings" to each "name:").